Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert product-os/flowzone/pull/953 #955

Merged
merged 1 commit into from
Mar 25, 2024
Merged

revert product-os/flowzone/pull/953 #955

merged 1 commit into from
Mar 25, 2024

Conversation

ab77
Copy link
Member

@ab77 ab77 commented Mar 25, 2024

  • installing Python dependencies on runner breaks other dependencies (e.g. AWS-CLI)

change-type: patch

@ab77 ab77 requested a review from klutchell March 25, 2024 19:47
@klutchell
Copy link
Collaborator

I prefer this approach rather than hardcoding runner tags.

@flowzone-app flowzone-app bot enabled auto-merge March 25, 2024 19:54
@ab77
Copy link
Member Author

ab77 commented Mar 25, 2024

I prefer this approach rather than hardcoding runner tags.

How is this approach fixing the underlying condition that the setup-python action will only currently succeed on X64/Linux? I must be missing something, perhaps you can add you commit directly to this branch?

We have seven environment repositories that are affected by this. We could technically change them all to only run on X64/Linux, but I think a one line change here is better than having to change x7, especially given that it will be temporary.

flowzone.yml Outdated Show resolved Hide resolved
@klutchell
Copy link
Collaborator

I prefer this approach rather than hardcoding runner tags.

How is this approach fixing the underlying condition that the setup-python action will only currently succeed on X64/Linux? I must be missing something, perhaps you can add you commit directly to this branch?

We have seven environment repositories that are affected by this. We could technically change them all to only run on X64/Linux, but I think a one line change here is better than having to change x7, especially given that it will be temporary.

HOW temporary? Do we know if/when this will be fixed upstream?

I see the benefit of fixing it in Flowzone as it's less work, but then we have to make assumptions about what the calling repository has access to (self-hosted vs GitHub hosted) AND we need to remember and come back later to remove all the places in Flowzone where we are ignoring the runs_on input to provide a hardcoded one.

Would this be a suitable compromise?

@ab77
Copy link
Member Author

ab77 commented Mar 25, 2024

Would this be a suitable compromise?

Ugh..

* installing Python dependencies on runner breaks other dependencies (e.g. AWS-CLI)

change-type: patch
@ab77
Copy link
Member Author

ab77 commented Mar 25, 2024

Would this be a suitable compromise?

Ugh..

We'll have to do it upstream and revert when they get their sh*t together.

@flowzone-app flowzone-app bot merged commit 07265c0 into master Mar 25, 2024
76 checks passed
@flowzone-app flowzone-app bot deleted the ab77/patch branch March 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants