Remove unnecessary input win redisplay #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redisplay function in keyboard handling event was introduced by @rodarima in the following commit: 7eac636 At the point first commit introduction it made sense, but later the following commit added proper handling of input redisplay. ccede06 This change was overlooked by me and introduced in profanity-im#1943. Potential solution for profanity-im#1947.
jubalh
approved these changes
Jan 19, 2024
jubalh
added a commit
that referenced
this pull request
Feb 19, 2024
Revert "Merge pull request #1943 from H3rnand3zzz/gmainloop This reverts commit 609fde0, reversing changes made to 2ec9406. Revert "Merge pull request #1948 from H3rnand3zzz/fix/rl-less-refreshes" This reverts commit 11762fd, reversing changes made to 609fde0. We have got several issues, that we don't quite see how to solve, with the merge of the gmainloop PR. * Slashguard is broken (#1955) (though #1956 could fix that) * One person reported problems with copy paste selection via mouse * Some input buffer seems not to be cleared correctly It happened that I was debugging profanity used `/connect` and typed the password. I then debugged so long that a time out occurred, so profanity disconnected. Then it printed "unknown command: $password". There was something else that I forgot now. Bottomline is: so far we didn't get it right so we will undo these changes until someone proposes a working solution. We got a slight performance increase (apparently noticable when alt+mouse scrolling) but got too many issues with this change.
|
Undone in 88b26cf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the functionality
/editorand write some stuff, after this save and close, input should be updated.