Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slashguard #1956

Closed
wants to merge 1 commit into from
Closed

Fix slashguard #1956

wants to merge 1 commit into from

Conversation

jubalh
Copy link
Member

@jubalh jubalh commented Feb 17, 2024

  • Need more time to investigate the callback stuff.
  • Need to check whether we need the slashguard check in two locations or not. If we do put it into a func.

Fix #1955

@jubalh
Fix slashguard
9b193b1 
Slashguard wasn't working since merging
#1943.

In 7eac636 the user input processing
was moved to be in gmainloop via inp_add_watch().

Fix #1955
@jubalh
Copy link
Member Author

jubalh commented Feb 18, 2024

@H3rnand3zzz can you review?

@jubalh jubalh self-assigned this Feb 18, 2024
@jubalh jubalh added this to the next milestone Feb 18, 2024
@jubalh jubalh marked this pull request as ready for review February 18, 2024 06:37
@jubalh jubalh changed the title WIP: slashguard fix Fix slashguard Feb 18, 2024
jubalh added a commit that referenced this pull request Feb 19, 2024
@jubalh
Undo gmainloop related changes
88b26cf 
Revert "Merge pull request #1943 from H3rnand3zzz/gmainloop

This reverts commit 609fde0, reversing
changes made to 2ec9406.

Revert "Merge pull request #1948 from H3rnand3zzz/fix/rl-less-refreshes"

This reverts commit 11762fd, reversing
changes made to 609fde0.

We have got several issues, that we don't quite see how to solve, with
the merge of the gmainloop PR.

* Slashguard is broken (#1955) (though #1956 could fix that)
* One person reported problems with copy paste selection via mouse
* Some input buffer seems not to be cleared correctly
  It happened that I was debugging profanity used `/connect` and typed
  the password. I then debugged so long that a time out occurred, so
  profanity disconnected. Then it printed "unknown command: $password".

There was something else that I forgot now.

Bottomline is: so far we didn't get it right so we will undo these
changes until someone proposes a working solution.

We got a slight performance increase (apparently noticable when
alt+mouse scrolling) but got too many issues with this change.
@jubalh
Copy link
Member Author

jubalh commented Feb 19, 2024

We undid the gmainloop changes instead. See 88b26cf.

@jubalh jubalh closed this Feb 19, 2024
@jubalh jubalh deleted the fix/slashguard-1955 branch February 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jubalh jubalh

Labels
improvement
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Slashguard doesn't work
1 participant
@jubalh