-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Add test logic to verify the subscription state in the Linux tv-casting-app. #33398
Merged
mergify
merged 6 commits into
project-chip:master
from
shaoltan-amazon:test-subscription-Linux
May 21, 2024
Merged
[Linux] Add test logic to verify the subscription state in the Linux tv-casting-app. #33398
mergify
merged 6 commits into
project-chip:master
from
shaoltan-amazon:test-subscription-Linux
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
May 9, 2024 22:23
PR #33398: Size comparison from 550b1c1 to eb394de Full report (6 builds for cc32xx, mbed, qpg, stm32)
|
sharadb-amazon
approved these changes
May 9, 2024
PR #33398: Size comparison from 550b1c1 to 58bcfa0 Decreases (2 builds for efr32)
Full report (80 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
…ased timeout values to prevent flaky test, and addressed PR comments from @sharadb-amazon.
shaoltan-amazon
force-pushed
the
test-subscription-Linux
branch
from
May 14, 2024 23:23
ef3a915
to
18f2d5c
Compare
PR #33398: Size comparison from c7f7984 to 18f2d5c Decreases (2 builds for efr32)
Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
chrisdecenzo
approved these changes
May 15, 2024
andy31415
reviewed
May 16, 2024
andy31415
reviewed
May 16, 2024
andy31415
reviewed
May 16, 2024
shaoltan-amazon
force-pushed
the
test-subscription-Linux
branch
from
May 20, 2024 20:00
3a647d7
to
b7e0d47
Compare
PR #33398: Size comparison from 6bd80b0 to b7e0d47 Decreases (1 build for efr32)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
hawk248
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33397
Problem
There is currently no CI check to verify that the Linux tv-casting-app is still subscribed to the
MediaPlayback
cluster and theCurrentState
(playback state) attribute whenever a PR is created.Solution Overview
Add test logic to the
run_tv_casting_test.py
file to verify the subscription state of the Linux tv-casting-app. The output will be written to the tv-casting-app log file.The following has been added to the test script:
ReportDataMessage
and validate theCluster
andAttribute
values against theMediaPlayback
cluster andCurrentState
attribute. The cluster and attribute values are0x506
and0x0000_0000
respectively. For reference, these values are set here for the cluster value and here for the attribute value.ReportDataMessage
with valid cluster and attribute values to console.ReportDataMessage
with valid cluster and attribute values within the timeout, then we print an error message, dump the logs to console, and exit on error.Testing
Tested the script locally by running
python3 ./scripts/tests/run_tv_casting_test.py
and observing the output. Also verified that the CI check works as expected.