-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance: add start of arithmetic conformance #33424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHIP-Specifications/connectedhomeip-spec#7808 represents the first arithmetic conformance operation. Adding a new conformance class to match this. Currently this just returns optional to match the current behaviour, but this will be changed in an upcoming PR (see project-chip#33422) However, thet change requires that we assess the conformance based on the attribute values, which we do pass in right now. This therefore requires a bit of an API change on the conformance classes and I've opted to address this in a separate PR to keep the changes compact.
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bauerschwan,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
May 13, 2024 14:43
pullapprove
bot
requested review from
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
May 13, 2024 14:44
PR #33424: Size comparison from add5b26 to 5511621 Full report (18 builds for cc13x4_26x4, cc32xx, mbed, nrfconnect, nxp, qpg, stm32)
|
PR #33424: Size comparison from add5b26 to 57c807d Full report (81 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
ReneJosefsen
approved these changes
May 17, 2024
yufengwangca
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7808 represents the first arithmetic conformance operation. Adding a new conformance class to match this. Currently this just returns optional to match the current behaviour, but this will be changed in an upcoming PR (see
#33422)
However, that change requires that we assess the conformance based on the attribute values, which we do pass in right now. This therefore requires a bit of an API change on the conformance classes and I've opted to address this in a separate PR to keep the changes compact.