Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NCLSUP-901] Use fixed version to fix clean build error for react-router-dom #234

Merged
merged 3 commits into from Jun 9, 2023

Conversation

DnsZhou
Copy link
Contributor

@DnsZhou DnsZhou commented Jun 8, 2023

@DnsZhou TODO update description with detail about package-lock.json

@DnsZhou DnsZhou requested a review from matedo1 June 8, 2023 02:13
@matedo1
Copy link
Contributor

matedo1 commented Jun 8, 2023

This PR downgrades react-router-dom:

There is new jira NCL-7924 to update it back once upstream fixed is done
Update: update is done, see #235

@DnsZhou
Copy link
Contributor Author

DnsZhou commented Jun 8, 2023

Hi @matedo1 , Thanks for summarizing the changes! shall we rebase the code to close the NCLSUP-901 jira?

@DnsZhou
Copy link
Contributor Author

DnsZhou commented Jun 8, 2023

This PR downgrades react-router-dom:

There is new jira NCL-7924 to update it back once upstream fixed is done.

NCL-7924 will be started after upstream PR has been merged & new react-router-dom version has been released: remix-run/react-router#10569

@matedo1
Copy link
Contributor

matedo1 commented Jun 8, 2023

PR is approved, feel free to merge it

@DnsZhou DnsZhou merged commit 4a98ba6 into project-ncl:main Jun 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants