Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names in comment #8711

Merged
merged 1 commit into from
May 15, 2024

Conversation

looklose
Copy link
Contributor

@looklose looklose commented Apr 10, 2024

Description

fix function names in comment

Related issues/PRs

Todos

  • Tests
  • Documentation
  • Release note

Release Note

 fix function names in comment

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@looklose looklose requested a review from a team as a code owner April 10, 2024 11:44
@marvin-tigera marvin-tigera added this to the Calico v3.29.0 milestone Apr 10, 2024
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Apr 10, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

@looklose
Copy link
Contributor Author

friendly ping~

apiserver/cmd/apiserver/server/server.go Outdated Show resolved Hide resolved
apiserver/pkg/storage/calico/resource.go Outdated Show resolved Hide resolved
Signed-off-by: looklose <shishuaiqun@yeah.net>
@nelljerram
Copy link
Member

/sem-approve

@nelljerram nelljerram added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact merge-when-ready delete-branch and removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels May 15, 2024
@marvin-tigera marvin-tigera merged commit e9f2fdd into projectcalico:master May 15, 2024
2 checks passed
@marvin-tigera
Copy link
Contributor

I'm sorry but I failed delete the branch after merging the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delete-branch docs-not-required Docs not required for this change merge-when-ready release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants