-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smb detect linux and windows #9561
Merged
DhiyaneshGeek
merged 6 commits into
projectdiscovery:main
from
Puben:smb-detect-linux-and-windows
Jun 5, 2024
Merged
Smb detect linux and windows #9561
DhiyaneshGeek
merged 6 commits into
projectdiscovery:main
from
Puben:smb-detect-linux-and-windows
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h both linux-based (Samba) smb servers and windows servers
…h both linux-based (Samba) smb servers and windows servers
Thanks so much for your contribution @Puben , we appreciate it! |
pussycat0x
added
the
Status: In Progress
This issue is being worked on, and has someone assigned.
label
Apr 18, 2024
Hi @Puben Hi, I rewrote this template for Samba detection. Please review it and let me know your thoughts.
|
That is a way cleaner way to do it! Very cool 👍 |
pussycat0x
added
Done
Ready to merge
and removed
Status: In Progress
This issue is being worked on, and has someone assigned.
labels
Jun 3, 2024
DhiyaneshGeek
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template / PR Information
While playing around with Nuclei for SMB stuff I noticed that the existing smb-detect template does not match on my Samba test setup. I believe this PR would match both Windows based SMB-servers and Samba SMB-servers.
Only changed the tag to include "linux" and condition from "and" to "or"
Attached screenshots for reference
Template Validation
I've validated this template locally?
Additional References: