Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getFragment method to ReactLocalization #595

Merged
merged 19 commits into from
Oct 27, 2022
Merged

Add getFragment method to ReactLocalization #595

merged 19 commits into from
Oct 27, 2022

Commits on Jul 9, 2022

  1. Add getFragment method to ReactLocalization 

    It's similar to getString(), but returns a React Fragment instead
of a string. The main added benefit here is that it allows the
caller to pass in `elems` analogous to the similarly-named prop on
<Localized>.
    @Vinnl
    Vinnl committed Jul 9, 2022
    Configuration menu
    Copy the full SHA
    04bb1a0 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Add getElement, redefine getFragment using it

    @Vinnl
    Vinnl committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    cdf5ea9 View commit details
    Browse the repository at this point in the history

  2. Re-define <Localized> using getElement

    @Vinnl
    Vinnl committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    695874d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. fixup! Add getElement, redefine getFragment using it

    @Vinnl
    Vinnl committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    435a08b View commit details
    Browse the repository at this point in the history

  2. Mark all empty ID values as invalid 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    29be3dd View commit details
    Browse the repository at this point in the history

  3. fixup! Add getElement, redefine getFragment using it

    @Vinnl
    Vinnl committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ab17fdb View commit details
    Browse the repository at this point in the history

  4. Use a Map for a record 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    a9b73ca View commit details
    Browse the repository at this point in the history

  5. Desructure a parameter 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    87c73d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. fixup! Use a Map for a record

    @Vinnl
    Vinnl committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    515918e View commit details
    Browse the repository at this point in the history

  2. Remove getFragment 

    It's a thin wrapper, so not worth it for now to spend additional
API surface area on, as per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    6027f43 View commit details
    Browse the repository at this point in the history

  3. Rename second getString parameter to vars 

    It's equivalent to the `vars` prop on <Localiszed> and the
respective parameter for getElement, holding Fluent variables.
    @Vinnl
    Vinnl committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    f2b728c View commit details
    Browse the repository at this point in the history

  4. fixup! Add getElement, redefine getFragment using it

    @Vinnl
    Vinnl committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    998e786 View commit details
    Browse the repository at this point in the history

  5. Filter out invalid elems on the first pass 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    b950f1c View commit details
    Browse the repository at this point in the history

  6. Only accept single element to render in getElement 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    59671cc View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Outsource one-element checking to Children.only 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    71dfc62 View commit details
    Browse the repository at this point in the history

  2. Empty-initialise unused parameter 

    As per
projectfluent#595 (comment)
    @Vinnl
    Vinnl committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dc130a5 View commit details
    Browse the repository at this point in the history

  3. Clarify variable name

    @Vinnl
    Vinnl committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dbfbdb5 View commit details
    Browse the repository at this point in the history

  4. Apply Prettier code styling

    @eemeli
    eemeli committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    8362f23 View commit details
    Browse the repository at this point in the history

  5. Revert React.Children.only use, rename componentToRender -> source in… 

    … Localized
    @eemeli
    eemeli committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dcf65c3 View commit details
    Browse the repository at this point in the history