[Catalog] Use production config+tree resources from Nessie Catalog #8539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.
adutra
reviewed
May 20, 2024
| @@ -32,6 +32,7 @@ dependencies { | |||
| implementation(project(":nessie-versioned-storage-common")) | |||
| implementation(project(":nessie-versioned-storage-inmemory")) | |||
| implementation(project(":nessie-versioned-storage-store")) | |||
| implementation(libs.guava) | |||
There was a problem hiding this comment.
Shall we move the combined client out of the testing folder?
There was a problem hiding this comment.
Want to do that, but in a separate PR.
| return new CombinedClientBuilder() | ||
| .withConfigResource(configResource) | ||
| .withTreeResource(treeResource) | ||
| .buildForProduction(NessieApiV2.class); |
There was a problem hiding this comment.
Do we really need the new method? Calling the old build method would yield the same result.
There was a problem hiding this comment.
Wanna give that another look separately. Potentially removing the code path in build() if it's not used anywhere.
adutra
approved these changes
May 21, 2024
snazy
merged commit d5dee3e
into
projectnessie:feature/nessie-catalog-server
16 checks passed
snazy
added a commit
that referenced
this pull request
May 24, 2024
…8539) The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.
snazy
added a commit
that referenced
this pull request
May 25, 2024
…8539) The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.
snazy
added a commit
that referenced
this pull request
May 25, 2024
…8539) The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.
snazy
added a commit
that referenced
this pull request
May 27, 2024
…8539) The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.
snazy
added a commit
that referenced
this pull request
May 27, 2024
…8539) The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nessie client used from Nessie Catalog is currently a "simple" one. This change lets it use a client that's configured against the actual config+tree resources, which also perform authZ.