-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(github): bump upload/download artifact actions to v4; resolves runtime deprecation warnings #3335
Conversation
7e46da8
to
f11e1a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
=======================================
Coverage 96.28% 96.29%
=======================================
Files 191 191
Lines 36709 36720 +11
Branches 3435 3436 +1
=======================================
+ Hits 35347 35360 +13
+ Misses 1362 1360 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you keep this limited to upload/download and split other actions in to separate PRs please?
…eprecation warnings
d686824
to
8d2b97b
Compare
Sure thing. Here's the separate PR |
Co-authored-by: Momo Kornher <mail@moritzkornher.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update artifact-related github actions that are generating warnings in projects due to nodejs 16 being deprecated in github actions runners.
v4 of actions/upload-artifact introduced some breaking changes, so we've set
overwrite
to be true by default to mirror the previous behavior as closely as possible.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.