enhancement: Skip more tasks when skipping install #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When not installing, /usr/local/bin/blackbox_exporter is not guaranteed to be present. Which means that applying cap_net_raw capability to it may fail and should be skipped too. This means that installing the libcap2-bin package may be unnecessary, if not contradicting the principle of the 'skip_install' setting. And the same goes for the installation of the python3-apt package in the preflight script. All of the above are irrelevant when using this role to setup the configuration of a container which comes with everything pre-installed. Signed-off-by: Thomas Venieris <thomas.venieris@gmail.com>
gardar
changed the title
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not installing, /usr/local/bin/blackbox_exporter is not guaranteed to be present. Which means that applying cap_net_raw capability to it may fail and should be skipped too. This means that installing the libcap2-bin package may be unnecessary, if not contradicting the principle of the 'skip_install' setting. And the same goes for the installation of the python3-apt package in the preflight script.
All of the above are irrelevant when using this role to setup the configuration of a container which comes with everything pre-installed.