feat: allow overriding _prometheus_binary_install_dir #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See prometheus-community#221 Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
dir-override
branch
from
c286b4e
to
1497675
Compare
anarcat
changed the title
|
LGTM any news from the maintainers ? |
|
Not a maintainer, just wondering: why not rename this variable to drop It's currently internal anyway so this change wouldn't be breaking the interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ideal as the variable is still prefixed with
_but it beats the current situation where it cannot be overriden at all.See #221