Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boolean flags when enabling collectors #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oneoneonepig
Copy link

When enabling boolean flags such as collector.systemd.enable-start-time-metrics, the flag must not specify any value.

Good:

  • --collector.systemd.enable-start-time-metrics

Bad:

  • --collector.systemd.enable-start-time-metrics=true
  • --collector.systemd.enable-start-time-metrics=True
  • --collector.systemd.enable-start-time-metrics=

To enable boolean flags, use the following method:

  roles:
    - role: prometheus.prometheus.node_exporter
      vars:
        node_exporter_enabled_collectors:
          - systemd:
              enable-start-time-metrics:

@oneoneonepig oneoneonepig changed the title [fix] Fix boolean flags when enabling collectors fix: boolean flags when enabling collectors Dec 7, 2023
@github-actions github-actions bot added bugfix and removed bugfix labels Dec 7, 2023
Signed-off-by: Jeffrey Chu <oneoneonepig@users.noreply.github.com>
@SuperQ
Copy link
Contributor

SuperQ commented Dec 7, 2023

Would you please add some molecule tests for this?

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs a molecule test.

@oneoneonepig
Copy link
Author

apologize for the late update, the development has been pending for a while; will include the tests in near future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants