Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : AlertManager Role, allow using web config file #267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat : AlertManager Role, allow using web config file #267

wants to merge 1 commit into from

Conversation

modship
Copy link

@modship modship commented Dec 19, 2023

This PR allow using web config file, in my case i need to use basic auth

Exemple :

alertmanager_web_config:
  basic_auth_users:
    John: $2a$12$9kqglntQUzvOFu2cvEYZ0.H6sXuho5Xdc.ID.C2hNtlCYF6q/RXWG
    Doe: $2a$12$sIB6/w8/4Fn5EWaAdrpSGuRqIhkrXzSnQSxOqbiSPhTbdHWkC.oKG

@modship modship changed the title Allow using web config file feat : Allow using web config file Dec 19, 2023
@modship modship changed the title feat : Allow using web config file feat : AlertManager Role, allow using web config file Dec 19, 2023
SuperQ
SuperQ requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not follow the implementation pattern of the other roles.

This needs a DCO sign-off. You can use git commit -s --amend to add it.

@modship
allow using web config file
6ea5710 
Signed-off-by: modship <yeskinokay@gmail.com>
@modship modship requested a review from SuperQ December 19, 2023 11:03
SuperQ
SuperQ requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to use ansible.builtin.template like the other roles do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ requested changes

Assignees
No one assigned
Labels
roles/alertmanager roles/chrony_exporter roles/memcached_exporter roles/mysqld_exporter roles/node_exporter roles/pushgateway roles/smartctl_exporter roles/smokeping_prober roles/systemd_exporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@modship @SuperQ