enhancement(node_exporter): use systemd to create node_exporter_textfile_dir if it doesn't exist #323
+10
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
SuperQ
requested changes
Mar 24, 2024
…ile_dir if it doesn't exist Signed-off-by: Siyuan Miao <i@xswan.net>
github-actions
bot
added
enhancement
SuperQ
reviewed
Mar 24, 2024
| {% if node_exporter_textfile_dir | length > 0 %} | ||
| {% if (ansible_facts.packages.systemd | first).version is version('235', '>=') %} | ||
| ExecStartPre=+/bin/mkdir -p {{ node_exporter_textfile_dir }} | ||
| ExecStartPre=+/bin/chown -R {{ node_exporter_system_user }}:{{ node_exporter_system_group }} {{ node_exporter_textfile_dir }} |
There was a problem hiding this comment.
Hmm, I wonder if this should be -R. I'm not sure we want all of the prom files changed, just the dir.
There was a problem hiding this comment.
In our environment, the text file exporters are started after node_exporter.service and the directory is used exclusively for text file exporters, so it doesn't really matter, but I think we can remove the -R, or should we go further and only change the owner if the directory is empty?
gardar
reviewed
Mar 24, 2024
There was a problem hiding this comment.
I wonder if using systemd tmpfiles in this scenario would be a better solution? https://www.freedesktop.org/software/systemd/man/latest/tmpfiles.d.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using a directory inside tmpfs for textfile collectors to reduce possible unnecessary IO usage, and the directory will be removed after a reboot. This PR is to ensure that
node_exporter_textfile_direxists when node-exporter is started.