fix: refresh AWS credentials if marked as expired #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Rogers <hellopatrick@users.noreply.github.com>
Signed-off-by: Patrick Rogers <hellopatrick@users.noreply.github.com>
Signed-off-by: Patrick Rogers <hellopatrick@users.noreply.github.com>
hellopatrick
force-pushed
the
refresh-aws-creds
branch
from
3b96bac
to
b470f02
Compare
|
I believe this also fixes #624, which I'm experiencing as well. After a certain amount of time, the temporary credentials fetched from IMDS expire and just get 403s afterwards. |
|
Hi, @sysadmind, would it be possible get a look/review? Thanks! |
sysadmind
added a commit
to sysadmind/elasticsearch_exporter
that referenced
this pull request
Oct 17, 2022
Use the AWS cached credential provider to automatically handle credentials. The CredentialsCache will automatically handle refreshing expired credentials and keeping them cached as long as necessary. Replaces prometheus-community#634 as this offloads more of the work to the AWS SDK Signed-off-by: Joe Adams <github@joeadams.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#597 adds support for AWS OpenSearch instances, but the credentials may expire if using the EC2 metadata endpoint (IMDS) to fetch credentials for signing.
As such, before sending request, we should check if the credentials have expired and refresh if need be.