Add Indices filter flag #764
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shahar Tal <stalmail10@gmail.com>
Closed
Signed-off-by: Shahar Tal <stalmail10@gmail.com>
sysadmind
requested changes
Aug 23, 2023
There was a problem hiding this comment.
I think this is pretty straightforward and overall looks pretty good. Thinking about how this is used, I think it would be better to call this an index selector instead of a filter. It's not filtering out indices, it is selecting which ones to get metrics for. That would make the flat es.indices_selector and would mean renaming the variables. Code-wise I think everything is okay.
Signed-off-by: Shahar Tal <stalmail10@gmail.com>
|
Thanks for the rename suggestion. |
|
@sysadmind |
sysadmind
requested changes
Nov 15, 2023
Modified. es.indices_selector description Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Shahar Tal <stalmail10@gmail.com>
|
@sysadmind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:this is a new PR in behalf of #574as the previous one has DCO issue and after trying to squash commit to sign all of them, it messed the PR so it has been decided to open a new one.
Original Description:As can be seen earlier, certain people asked for the option to filter (IN) the indices which are exported.
Especially if you have a lot of them and you need to monitor just certain, the rest of it, is just a waste of resources.
ATM, fetching indices settings/stats/mappings queries all the existing ones using this kind of GET requests:
GET /_all/_settings,GET /_all/_statsandGET /_all/_mappingsAs mentioned in the docs:
https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-settings.html
It's possible to just retrieve the ones which match 2 types of queries:
Matching using wildcard(*) expression. i.e:
GET /prefix_*/_statsMatching a list of indices, using comma:
GET /first_name,second_name/_statsIt is possible to mix them both. ie:
GET /prefix_1_*,prefix_2_*/_statsThe new added flag:
es.indices_selector(default is '_all')Note: The flag will be used only if any export indices flag is used.
To use it, pass an expression to match your use-case indices, default '_all' just like before.
By passing one of the options mentioned above as a value (statement with a wildcard, list with commas), it will be used in the http request to retrieve statistics.
This change would be very appreciated,
Thanks.