Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] ICMP: Suggest setting net.ipv4.ping_group_range in podSecurityContext #3616

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fatz
Copy link

@fatz fatz commented Jul 19, 2023

What this PR does / why we need it

To enable ICMP probes net.ipv4.ping_group_range must be set in some environments.

This PR adds a hint to the release notes aside of the hint to set securityContext.capabilities.add: ["NET_RAW"] for enabling ICMP.

This will IMO make it easier for users to get ICMP probes working

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Add hint to set `net.ipv4.ping_group_range`

Signed-off-by: Jan Ulferts <jan@janulferts.de>
@zeritti zeritti changed the title ICMP: Suggest setting net.ipv4.ping_group_range in podSecurityContext [prometheus-blackbox-exporter] ICMP: Suggest setting net.ipv4.ping_group_range in podSecurityContext Jul 28, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some text should be added why its needed and maybe in which environments.
also chart version needs to be updated.

@stale stale bot removed the lifecycle/stale label Sep 27, 2023
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot removed the lifecycle/stale label Jan 8, 2024
Copy link
Member

@monotek monotek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart version needs to be updated

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants