Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alertmanager-snmp-notifier] Update README with correct chart name #3789

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FalkW
Copy link

@FalkW FalkW commented Sep 12, 2023

As the name of the chart was changes an update in the README.md is required to reflect this change.

What this PR does / why we need it

So the user is able to install the chart by following the readme.

The current one is wrong:

helm install test  prometheus-community/snmp-notifier
Error: INSTALLATION FAILED: chart "snmp-notifier" matching  not found in prometheus-community index. (try 'helm repo update'): no chart name found

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

As the name of the chart was changes an update in the README.md is required to reflect this change.

Signed-off-by: Falk  <Falkw1@gmx.de>
@zeritti zeritti changed the title Update README.md with correct chart name [alertmanager-snmp-notifier] Update README with correct chart name Sep 16, 2023
@zeritti
Copy link
Member

zeritti commented Sep 16, 2023

Thank you, @FalkW, for your PR. Please, raise the chart's version number in Chart.yaml.

Signed-off-by: Falk  <Falkw1@gmx.de>
@FalkW
Copy link
Author

FalkW commented Sep 16, 2023

Thank you, @FalkW, for your PR. Please, raise the chart's version number in Chart.yaml.

Done.

@zeritti
Copy link
Member

zeritti commented Sep 16, 2023

Please, check your commits' signatures - DCO check is not passing.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Signed-off-by: Falk  <Falkw1@gmx.de>
Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants