[prometheus-consul-exporter] bump consul exporter to 0.12.0 #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrFaust92
force-pushed
the
consul-exporter
branch
from
bc6a40a
to
45b7d7d
Compare
|
The values file needs to be amended as the exporter release 0.9 does not start with an invalid consulServer: host:portAs users set their own Consul server name, setting the default to localhost makes the exporter start successfully (and is a reasonable value afterall). consulServer: "localhost:8500" |
|
@zeritti done, should this be considered a breaking change? |
In my opinion, no, not at all. |
DrFaust92
force-pushed
the
consul-exporter
branch
2 times, most recently
from
20530c1
to
4d0a6db
Compare
DrFaust92
force-pushed
the
consul-exporter
branch
from
4913cc4
to
bf46ca7
Compare
DrFaust92
force-pushed
the
consul-exporter
branch
from
bf46ca7
to
b7eed66
Compare
DrFaust92
force-pushed
the
consul-exporter
branch
from
b7eed66
to
fd9f9d2
Compare
DrFaust92
changed the title
DrFaust92
force-pushed
the
consul-exporter
branch
from
fd9f9d2
to
521db77
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
DrFaust92
changed the title
|
@zeritti any way we can merge this? other maintainers dont seem to respond 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])