[kube-prometheus-stack] fix failure-policy on patch-webhook job #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbadstuebner
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
jonasbadstuebner
force-pushed
the
kube-prometheus-stack-failure-policy-fix
branch
from
20ad7c2
to
aa3fcec
Compare
3 tasks
|
Pleas bump the chart version, thanks! |
|
@DrBu7cher Please resolve the conflicts. |
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
Signed-off-by: Miroslav Hadzhiev <miroslav.hadzhiev@gmail.com>
jkroepke
reviewed
Jan 22, 2024
...theus-stack/templates/prometheus-operator/admission-webhooks/job-patch/job-patchWebhook.yaml
Show resolved
Hide resolved
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GMartinez-Sisti
What this PR does / why we need it
This PR fixes the following error message on the admission-patch:
by not directly using the value from the HelmRelease-Values.
This error occurs, if you set
.Values.prometheusOperator.admissionWebhooks.failurePolicytoIgnoreOnInstallOnlyin the current version of the Chart.It also adds a new helper function for determining the correct
failurePolicybased on the values.Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])