[kube-state-metrics] Ignore global values for kube-state-metrics #4337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Currently, I can set
.Values.global.imageRegistry
in thekube-prometheus-stack
chart and this value will be used for all images in the chart and subcharts.So, if I want to use my private registry for all images, I have two options:
/kube-state-metrics/kube-state-metrics
,/prometheus/alertmanager
)Almost all images in the chart are located in the
quay.io
registry, butkube-state-metrics
image is fromregistry.k8s.io
.Private registries often use pull trough cache, so there is no option to keep original path in the registry. Path must start with the prefix, depending on the source registry.
i.e.
registry.k8s.io/kube-state-metrics/kube-state-metrics
=>private.registry.com/k8s/kube-state-metrics/kube-state-metrics
I suggest a third option:
.Values.ignoreGlobal
flag inkube-state-metrics
chart to ignore it. Then I can safely override registry via.Values.kube-state-metrics.image.registry
and there will be less overrides in my value file.Special notes for your reviewer
This w/a is kinda janky, please let me know if you have a better w/a for the problem.
Checklist
[prometheus-couchdb-exporter]
)