[kube-prometheus-stack] let additionalRuleGroupLabels override additionalRuleLabels #4395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR ensures that rule annotations and labels that are specific to a rule group -- i.e., the ones set in
.Values.defaultRules.additionalRuleGroup(Labels|Annotations)
-- will override values set in the global defaults (e.g..defaultRules.additionalRuleLabels
). Specifically, this change allows the following configuration, which applies a global label except to rules which would break if such labels were applied.This provides a workaround to #3396, where a rule in
kube-apiserver-availability.rules
will fail when labels are applied to it.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer
I am unsure if releases are performed for every PR, or PRs are held for larger releases. As such I have not bumped the chart version for this PR. Please let me know if I should do so, thanks.
Checklist
[prometheus-couchdb-exporter]
)