[kube-prometheus-stack] small rewrite of kube-prometheus-stack/README.md for easier understanding #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Bartsch <7559494+dominik-ba@users.noreply.github.com>
dominik-ba
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
|
Hi, sound great to me. Please highlight, that Prometheus rules and dashboard are coming from https://github.com/prometheus-operator/kube-prometheus. And also please bump the chart version. |
dominik-ba
commented
Apr 4, 2024
dominik-ba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This is a documentation / Readme change only
I personally think this little change of the intro improves the readme for easier understanding what is happening when one deploys this chart. Adding the operator only as a very last comment to me was always confusing because after all its not only a stack that deploy individual instances but uses the operator at its core. Happy to discuss.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])