[kube-prometheus-stack] Update mixins, switch to kube-prometheus mixin, add grafana rules and fix label aggregation in TargetDown alert #4460
Conversation
…n and fix label aggregation in TargetDown alert Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
jkroepke
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
| 'grafana_rules': ' .Values.defaultRules.rules.grafana', | ||
| 'GrafanaAlerts': ' .Values.defaultRules.rules.grafana', |
There was a problem hiding this comment.
Two questions:
- are these supposed to be the same?
- can we rename
GrafanaAlertstografana-alertsto make it similar with the other names and filenames?
There was a problem hiding this comment.
can we rename GrafanaAlerts to grafana-alerts to make it similar with the other names and filenames?
I saw this, too. Currently, the file name based on the rule group name, which behave differently at Grafana. But i can add a replacement for this, like to snake case.
are these supposed to be the same?
GrafanaAlerts has an dependency against grafana_rules. And there are just 2 rules in total. I thought, its fine to group them. But I'm also open separate them.
No strong opinion here.
| 'git': 'https://github.com/prometheus-operator/kube-prometheus.git', | ||
| 'branch': refs['ref.kube-prometheus'], | ||
| 'source': 'main.libsonnet', | ||
| 'cwd': 'jsonnet/kube-prometheus', | ||
| 'destination': '../templates/prometheus/rules-1.14', |
There was a problem hiding this comment.
should we remove the -1.14 postfix?
There was a problem hiding this comment.
It feel like it make sense, maybe it's something for an follow-up PR?
What this PR does / why we need it
Switch to jsonnet which generates all rules now by default (including the new grafana one)
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])