[prometheus] Add CI test cases #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com>
zeritti
requested review from
gianrubio,
naseemkullah,
Xtigyro and
zanhsieh
as code owners
|
cc @zanhsieh |
zanhsieh
approved these changes
Apr 25, 2024
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
* [prometheus] Add CI values files Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> * Use helper template setting labels in clusterrole Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> --------- Signed-off-by: zeritti <47476160+zeritti@users.noreply.github.com> Co-authored-by: MH <zanhsieh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The chart does not currently have any specific test cases to run in CI tasks and as a result, many fields and scenarios remain untested. This PR adds a few test cases setting fields that are otherwise unset or commented out.
Which issue this PR fixes
None
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])