Update kubernetes-apps.yaml #4481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update annotations to use dynamic time variables from the "for" key instead of hardcoded 15-min/1h durations. Previously, time durations were hardcoded as 15 minutes/1h in various annotations. This commit replaces these static values with dynamic variables sourced from the "for" key. This change improves flexibility and maintainability, ensuring that the annotations accurately reflect configured time durations. Signed-off-by: a7lan <as_lan@bk.ru>
a7lan
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
|
Hi, thanks for you contribution. However all files insides rules-1.14 directory are auto-generated by an python script. In case I would merge this, the changes are getting reverted by next person who execution the script. Please adjust the script https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/hack/sync_prometheus_rules.py to include your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update annotations to use dynamic time variables from the "for" key instead of hardcoded 15-min/1h durations.
Previously, time durations were hardcoded as 15 minutes/1h in various annotations. This commit replaces these static values with dynamic variables sourced from the "for" key. This change improves flexibility and maintainability, ensuring that the annotations accurately reflect configured time durations.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])