[prometheus-snmp-exporter] Extend metric relabels #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In addition to fixed '$key: $value' metric relabelings, allow arbitrary relabel configs in order to support e.g. common label prefixes Signed-off-by: ngc4579 <distant.calls@gmail.com>
walker-tom
requested changes
Apr 27, 2024
Apply suggested changes Co-authored-by: Tom Walker <walker.thomas.p@gmail.com> Signed-off-by: ngc4579 <distant.calls@gmail.com>
Apply suggested changes Co-authored-by: Tom Walker <walker.thomas.p@gmail.com> Signed-off-by: ngc4579 <distant.calls@gmail.com>
walker-tom
approved these changes
Apr 28, 2024
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
…ty#4490) * [prometheus-snmp-exporter] Extend metric relabels - In addition to fixed '$key: $value' metric relabelings, allow arbitrary relabel configs in order to support e.g. common label prefixes Signed-off-by: ngc4579 <distant.calls@gmail.com> * Update charts/prometheus-snmp-exporter/values.yaml Apply suggested changes Co-authored-by: Tom Walker <walker.thomas.p@gmail.com> Signed-off-by: ngc4579 <distant.calls@gmail.com> * Update charts/prometheus-snmp-exporter/values.yaml Apply suggested changes Co-authored-by: Tom Walker <walker.thomas.p@gmail.com> Signed-off-by: ngc4579 <distant.calls@gmail.com> --------- Signed-off-by: ngc4579 <distant.calls@gmail.com> Co-authored-by: Tom Walker <walker.thomas.p@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@walker-tom @xiu @Miouge1
What this PR does / why we need it
Metric relabeling is currently limited to fixed label replacements .
In order to support arbitrary relabel configs, a new value
serviceMonitor.additionalMetricsRelabelConfigsresp.serviceMonitor.params.additionalMetricsRelabelConfigshas been introduced.Checklist
[prometheus-couchdb-exporter])