[kube-prometheus-stack] remove job ttl api check

[DrFaust92]

What this PR does / why we need it

Removes api check for ttlSecondsAfterFinished as the job resource is already batch/v1 so the check for batch/v1alpha1 is redundent.
It also allows overriding the existing value.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes [kube-prometheus-stack] deployment via argocd stuck in "pending deletion" for kube-prometheus-stack-admission-create job #4500

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[jkroepke]

LGTM 👍

[tulsluper]

When I try to install the chart 58.3.1 with ArgoCD - it stucks on "waiting for completion of hook batch/Job/kube-prometheus-stack-admission-create".
Everything fine with 58.3.0

Argo app additional settings:

• ServerSideDiff=true
• Server-Side Apply

[jkroepke]

Seems like an known bug in ArgoCD: argoproj/argo-cd#8586

Since there is a different behavior between ttlSecondsAfterFinished: 0 and ttlSecondsAfterFinished is omit, we need a condition, where 0 is true-ish, but empty value is false.

What about this?

  {{- if not (eq (print .Values.prometheusOperator.admissionWebhooks.patch.ttlSecondsAfterFinished) "") }}
  ttlSecondsAfterFinished: {{ .Values.prometheusOperator.admissionWebhooks.patch.ttlSecondsAfterFinished }}
  {{- end }}

With that condition, it would be possible to omit ttlSecondsAfterFinished completely to establish ArgoCD compatibility.

[reefland]

Seeing waiting for completion of hook batch/Job/prometheus-admission-create, unlike @tulsluper , I have to roll-back to 58.2.2, as 58.3.0 also hangs.