Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd unit and timer for smartmon #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LukeLR
Copy link

@LukeLR LukeLR commented Aug 26, 2023

I added systemd unit and timers for smartmon.sh, so they can be easily installed for running the smartmon script periodically as a service. What do you think? :)

@dswarbrick
Copy link
Member

Generally we leave such things to the distros which package the contents of this repo, since it usually involves distro-specific paths and users. For example, the Debian (and Ubuntu) package prometheus-node-exporter-collectors already includes systemd units and timers for five of the scripts in this repo.

@LukeLR
Copy link
Author

LukeLR commented Aug 26, 2023

Thanks for the reply. That's unfortunate, especially since no distro-specific paths are required if the scripts are simply installed in $PATH. I'd like to see sytemd units upstream, even if distros package systemd units, they can use them as an example. But if you don't want that in, I'll maintain a fork for myself.

@dswarbrick
Copy link
Member

I think that if we're going to include such things in this repo, they belong in a "contrib" directory, rather than the root directory. You'll also need to sign the DCO if you wish these to be considered for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants