Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting different root dir for apt #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egvimo
Copy link

@egvimo egvimo commented Sep 18, 2023

See #171

Implemented as command line argument instead of env var.

Additionally I've refactored a little bit. Fixed linting issues and created a separate function to use in other scripts.

@macetw
Copy link

macetw commented Oct 6, 2023

Definitely needed to manage within a docker container. Suggest moving this forward.

@macetw
Copy link

macetw commented Oct 6, 2023

This PR is only managing it for the apt script. Do we need this setting for any of the other scripts in this code?

A quick glance found deleted_libraries.py would require this change. fstab_check.sh. Gosh all of them?

@egvimo
Copy link
Author

egvimo commented Oct 10, 2023

I've created an exporter using the script from this PR which runs inside a Kubernetes cluster inside a container exporting the metrics via ServiceMonitor: https://github.com/egvimo/apt-exporter
This works even with a read only mount of the host directory.

@anarcat
Copy link
Contributor

anarcat commented Oct 11, 2023

should this be merged, or should we look at removing apt_info.py in favor of the apt-exporter?

@dswarbrick
Copy link
Member

dswarbrick commented Oct 12, 2023

should this be merged, or should we look at removing apt_info.py in favor of the apt-exporter?

If we remove a script simply because a dedicated exporter exists, then we would also need to remove the smartmon.{py,sh} and ipmitool scripts.

@anarcat
Copy link
Contributor

anarcat commented Oct 12, 2023

If we remove a script simply because a dedicated exporter exists, then we would also need to remove the smartmon.{py,sh} and ipmitool scripts.

that would solve #119 at least :p

Signed-off-by: egvimo <egvimo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants