Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port zfs_zpool.sh to Python #189

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Port zfs_zpool.sh to Python #189

wants to merge 6 commits into from

Conversation

lstrojny
Copy link
Contributor

  • Ports the shell script to Python
  • Introduces new metrics from zfs_status

New metrics

zfs_zpool_status The status of the zpool
zfs_zpool_vdev_info Information about the vdevs in a zpool
zfs_zpool_scrub_duration_seconds The duration of the latest zpool scrub in seconds
zfs_zpool_scrub_corrected_bytes The number of corrected bytes of the latest zpool scrub
zfs_zpool_scrub_time_seconds The timestamp of the latest zpool scrub
zfs_zpool_resilvering_duration_seconds The duration of the latest zpool scrub in seconds
zfs_zpool_resilvering_corrected_bytes The number of corrected bytes of the latest zpool scrub
zfs_zpool_resilvering_time_seconds The timestamp of the latest zpool scrub

@lstrojny lstrojny force-pushed the zfs_zpool-python branch 2 times, most recently from 6089f58 to cdfb7ed Compare November 23, 2023 13:55
@lstrojny
Port shell script
e01582f 
Signed-off-by: Lars Strojny <lars@strojny.net>
@lstrojny
Expose zpool status metrics
06e5288 
Signed-off-by: Lars Strojny <lars@strojny.net>
@lstrojny
Formatting
8dfe64e 
Signed-off-by: Lars Strojny <lars@strojny.net>
@lstrojny
Formatting
e523b05 
Signed-off-by: Lars Strojny <lars@strojny.net>
@lstrojny
Formatting
09de64a 
Signed-off-by: Lars Strojny <lars@strojny.net>
@lstrojny
Complete types
ba18f41 
Signed-off-by: Lars Strojny <lars@strojny.net>
@SuperQ
Copy link
Contributor

SuperQ commented Nov 24, 2023

Are the ZFS scripts necessary anymore? The node_exporter has a full ZFS collector module now.

@lstrojny
Copy link
Contributor Author

Yup, the metrics provided here are not exposed by node exporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lstrojny @SuperQ