Gitlab Collector: Autovacuum active collector and test #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2023
sysadmind
reviewed
Jun 29, 2023
| defer rows.Close() | ||
|
|
||
| for rows.Next() { | ||
| var phase, mode string |
There was a problem hiding this comment.
It would seem that the phase label would change often during vacuum, correct? That would change this time series often.
There was a problem hiding this comment.
It doesn't change terribly often, depends on the size of the table
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Co-authored-by: Joe Adams <github@joeadams.io> Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Signed-off-by: Felix Yuan <felix.yuan@reddit.com>
Sticksman
force-pushed
the
cleanup/gitlab-exporter-autovac-active
branch
from
ee961f2
to
589bb25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add some more escapes to make tests work
Split from #819