fix: longRunningTransactionsAgeInSeconds #978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clock_timestamp will just return the current timestamp - what we actually want to know is the lowest timestamp of the xact_start column Signed-off-by: Roman Pertl <roman@pertl.org>
roock
force-pushed
the
roock_fix_longest_query_seconds
branch
from
5e3acfc
to
11c9972
Compare
|
The collector for long running transactions is not telling anything about long running transactions. Can we get this reviewed and merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also see:
#836 (comment)
and the original can be found here:
https://gitlab.com/gitlab-cookbooks/gitlab-exporters/-/blob/master/templates/postgres_exporter/queries.yaml.erb#L954
(the originally proposed version
MAX(EXTRACT(EPOCH FROM (clock_timestamp() - xact_start))) AS age_in_secondsis also correct, but return the seconds, not the timestamp.Using the current version the graphs look like this (flat line as this will always match the current time):
