Make device exlude/include able to filter by device type and protocol #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekert
force-pushed
the
better_exclude
branch
2 times, most recently
from
293e225
to
b1955ff
Compare
Make regex also search inside a device type and protocol fields instead of a hardware name that can change on hardware change/reset. Signed-off-by: tekert <tekert@gmail.com>
|
This is a simple fix, but it would be better if the user could specify in the regex if they want filtering by protocol, name or type. I'm thinking of creating temp strings with this format |
Filter regex with the following string format "name=<deviceName>;type=<deviceType>;protocol=<deviceProtocol>" Signed-off-by: tekert <tekert@gmail.com>
tekert
changed the title
|
Fix for #72 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make regex also search inside a device type and protocol fields instead of a hardware name that can change on hardware change/reset.