Add support for GitHub codespaces and minor cleanup #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Randall <David@NiceGuyIT.biz>
Signed-off-by: David Randall <David@NiceGuyIT.biz>
Chg: Add support for GitHub codespaces (devcontainers) Chg: Minor cleanup Signed-off-by: David Randall <David@NiceGuyIT.biz>
Signed-off-by: David Randall <David@NiceGuyIT.biz>
|
What are the codespaces for? Can you add a bit of a "why" to the PR description? |
Done. Thank you for the reminder. I should have explained in the PR. |
robbat2
approved these changes
Nov 25, 2023
|
Hmm, interesting idea. I think something like this should be discussed with the wider Prometheus dev community. It would be better to support this kind of thing consistently across all projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chg: Add support for GitHub codespaces (devcontainers)
Chg: Move scripts to
scripts/directoryUpdated:
GitHub Codespaces provides a dev environment (VM) in the cloud. The goal is to be able to easily test PRs without doing a
git clone. To accomplish that, a Codespace can be started, thesmartctl_exporteris compiled and run, and a port is exposed to view the data. This can be done onmasterin this repo, and then checking out the PR commit. (I don't think Codespaces can be started from a PR commit.) Once done, the Codespace can be deleted. watchexec and just/task are cross platform which will help when working on Windows support (issue #163). watchexec and just/task will be in a separate PR.