New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info about filters to docs and rename struct fields #198
base: master
Are you sure you want to change the base?
Add more info about filters to docs and rename struct fields #198
Conversation
744ff37
to
68f0b54
Compare
This looks good, is there someone who can review it? |
I think only @SuperQ can approve PR's ATM |
Hey @SuperQ - I'm bumping into this again, It would really save me a tonne of bother if we could get this approved. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase.
507f6b3
to
d55e8dd
Compare
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
Signed-off-by: Kyle Eckhart <kgeckhart@users.noreply.github.com>
d55e8dd
to
1ec3046
Compare
Should be good to go now @SuperQ |
Adjusts the way
monitoring.filters
are documented and applied.Similar to #165, I found it hard to use the filters initially so hopefully more detailed docs can help. Especially related to the fact that the
monitoring.filters
flag should be specified multiple times vs comma delimited like other multi-valued params.This also adjusts the way the filters are applied to be based on prefix vs contains, 507f6b3. I think the original contains implementation made it hard to define what exactly belongs in the first section of the extra_filters. Forcing it to be a prefix makes it a lot more concrete.