Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduled_task: Move OLE connection to collect function #1451

Merged
merged 1 commit into from May 11, 2024

Conversation

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
Copy link
Member Author

@mattdurham does fix the issue on your side?

Connecting to OLE during collect should also increase the support for multiple instances and reduce the locking to an minimum.

On my local system, I do not longer had issues.

@jkroepke jkroepke marked this pull request as ready for review April 21, 2024 16:20
@jkroepke jkroepke requested a review from a team as a code owner April 21, 2024 16:20
@mattdurham
Copy link
Contributor

I think it should but will verify

@breed808
Copy link
Contributor

breed808 commented May 3, 2024

@mattdurham did you manage to verify the change?

@jkroepke jkroepke mentioned this pull request May 5, 2024
@jkroepke jkroepke added this to the v0.26.0 milestone May 6, 2024
@jkroepke
Copy link
Member Author

@breed808 otherwise, if you agree - take a review and merge it.

It was wrong anyways to construct the OLE init on builder func. If the issue is not resolved, feedback can be applied in #1425

Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jkroepke jkroepke merged commit 00781db into prometheus-community:master May 11, 2024
5 checks passed
@jkroepke jkroepke deleted the fix-task-scheudler branch May 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with scheduled_task
3 participants