Add label user to process collector #1472
Conversation
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
…ows_exporter into feature/collector/process
Signed-off-by: Andrey Burtasov <andrey.a.burtasov@gmail.com>
There was a problem hiding this comment.
I tested this PR on my local system and it works.
However, I see that the collector is 10 times slower compared to master branch.
master:
windows_exporter_collector_duration_seconds{collector="process"} 0.0121184
PR:
windows_exporter_collector_duration_seconds{collector="process"} 0.1610989
Thats to much. I have provide some suggestions, I hope they help. After apply the suggestion, verify locally, if everything still works as expected.
|
|
||
| err := wmi.Query(win32LoggedOnUserQuery, &users) | ||
| if err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
If the error occurs, the error should be returned as return value. Currently, there is just printed and the function continue, result into more errors.
|
|
||
| err = wmi.Query(win32SessionProcessQuery, &sessionProcesses) | ||
| if err != nil { | ||
| fmt.Println(err) |
There was a problem hiding this comment.
If the error occurs, the error should be returned as return value. Currently, there is just printed and the function continue, result into more errors.
| matchps := reps.FindStringSubmatch(sesessionProcess.Dependent) | ||
| number := matchps[1] | ||
|
|
||
| processMap[number] = fullname |
There was a problem hiding this comment.
Add a break here. If we found the user, we the break the search. This saves unnecessary extra loops.
| processMap[number] = fullname | |
| processMap[number] = fullname | |
| break |
| @@ -261,6 +278,7 @@ type WorkerProcess struct { | |||
|
|
|||
| func (c *collector) Collect(ctx *types.ScrapeContext, ch chan<- prometheus.Metric) error { | |||
| data := make([]perflibProcess, 0) | |||
| processMap := getUserProcess() | |||
There was a problem hiding this comment.
With the error returned, add a log warning here
like:
| processMap := getUserProcess() | |
| processMap, err := getUserProcess() | |
| if err != nil { | |
| _ = level.Warn(c.logger).Log("msg", "Could not query users for processes", "err", err) | |
| } |
| @@ -301,6 +319,7 @@ func (c *collector) Collect(ctx *types.ScrapeContext, ch chan<- prometheus.Metri | |||
| processName, | |||
| pid, | |||
| cpid, | |||
| processMap[pid], | |||
There was a problem hiding this comment.
We should add a fail-safe here, in case processMap[pid] may not hit, we have a panic here. Add a check, if the keys exists and return unknown
There was a problem hiding this comment.
I tested this PR on my local system and it works.
However, I see that the collector is 10 times slower compared to master branch.
master:
windows_exporter_collector_duration_seconds{collector="process"} 0.0121184
PR:
windows_exporter_collector_duration_seconds{collector="process"} 0.1610989
Thats to much. I have provide some suggestions, I hope they help. After apply the suggestion, verify locally, if everything still works as expected.
Added label "user" to process collector. Using WIN32_LoggedOnUser and Win32_SessionProcess
Example metric with new label:
HELP windows_process_cpu_time_total Returns elapsed time that all of the threads of this process used the processor to execute instructions by mode (privileged, user).
TYPE windows_process_cpu_time_total counter
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="17512",user="MYDOMAIN\aburtasov"} 0.296875
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="19688",user="MYDOMAIN\aburtasov"} 14.296875
windows_process_cpu_time_total{creating_process_id="12244",mode="privileged",process="powershell",process_id="25612",user="MYDOMAIN\aburtasov"} 0.484375