Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e test on secret update for PrometheusAgent #6414

Open
simonpasquier opened this issue Mar 20, 2024 · 2 comments · May be fixed by #6426
Open

Add e2e test on secret update for PrometheusAgent #6414

simonpasquier opened this issue Mar 20, 2024 · 2 comments · May be fixed by #6426
Assignees
@jamshidi799

Comments

@simonpasquier
Copy link
Contributor

simonpasquier commented Mar 20, 2024 •
edited 

          Ideally we'd need an e2e test to verify this but it's a bit more involved. I also think that we should reduce code duplication since all controllers have similar patterns for configmap/secret handlers but again it doesn't need to be in this be in this PR.

Originally posted by @simonpasquier in #6412 (review)
@jamshidi799
Copy link
Contributor

@slashpai may I pick this issue?

@jamshidi799 jamshidi799 linked a pull request Mar 23, 2024 that will close this issue
Open
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 21, 2024
@ArthurSens ArthurSens removed the stale label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamshidi799 jamshidi799

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add e2e test on secret update for PrometheusAgent jamshidi799/prometheus-operator
3 participants
@simonpasquier @ArthurSens @jamshidi799