Add e2e test on secret update for PrometheusAgent #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
reviewed
Apr 3, 2024
|
Thanks for tackling this issue anyway! I'm not entirely sure how this can be tested as well, some ideas that I had:
|
|
Since we're looking at end-to-end tests, I would tackle it from the end-user's standpoint: "I updated the credentials used to connect to my target but the update was never propagated to Prometheus and scrapes started to fail". In practice:
|
Signed-off-by: Mohammad Jamshidi <jamshidi.m799@gmail.com>
ArthurSens
reviewed
May 7, 2024
| t.Fatal(err) | ||
| } | ||
|
|
||
| time.Sleep(time.Minute * 2) |
There was a problem hiding this comment.
I believe WaitForHealthyTargets already waits until it finds the healthy targets. What do you think about removing this sleep then?
Comment on lines
+278
to
+280
| if err := framework.WaitForHealthyTargets(context.Background(), ns, "prometheus-agent-operated", 1); err == nil { | ||
| t.Fatal("All targets should be down") | ||
| } |
There was a problem hiding this comment.
If all targets should be down, why do we look for 1 healthy target?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes #6414
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Verification
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.