Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change suffix of testdata that is used as input to .input #6455

Open
ArthurSens opened this issue Apr 1, 2024 · 2 comments
Open

Change suffix of testdata that is used as input to .input #6455

ArthurSens opened this issue Apr 1, 2024 · 2 comments
Labels
area/testing good first issue

Comments

@ArthurSens
Copy link
Member

ArthurSens commented Apr 1, 2024 •
edited 

It took me forever to understand why such a simple change (changing separator to pointer), would change so much a golden file, e.g. source labels, action, etc.

That was until I realized that this file is not really a golden file by definition, but an input! We should change the suffix of this file to something else, e.g. `.input`

Originally posted by @ArthurSens in #6425 (comment)
@ArthurSens
Copy link
Member Author

There might be other files, not just this one mentioned in the issue above

@Ayush9026
Copy link

/assign @Ayush9026 i will solve this.

@Ayush9026 Ayush9026 mentioned this issue Apr 6, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change suffix of testdata that is used as input to .input Ayush9026/prometheus-operator
2 participants
@ArthurSens @Ayush9026