Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change suffix of testdata that is used as input to .input #6483

Conversation

Ayush9026
Copy link

@Ayush9026 Ayush9026 commented Apr 6, 2024

Description

This PR fixes #6455 this issue.
Change suffix of testdata that is used as input to .input.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Update file naming conventions from testdata to .input in specified test files.

@Ayush9026 Ayush9026 requested a review from a team as a code owner April 6, 2024 10:41
@simonpasquier
Copy link
Contributor

This isn't what was expected. The change should only rename some .golden files and update the corresponding unit tests.

@Ayush9026 Ayush9026 closed this by deleting the head repository May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change suffix of testdata that is used as input to .input
2 participants