Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prometheus/common #6376

Merged
merged 1 commit into from Mar 7, 2024
Merged

Bump prometheus/common #6376

merged 1 commit into from Mar 7, 2024

Conversation

ArthurSens
Copy link
Member

Description

We moved the collector upstream to solve a circular dependency between client_golang and common 馃槵

prometheus/common#591
prometheus/client_golang#1422

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
@ArthurSens ArthurSens requested a review from a team as a code owner March 7, 2024 12:29
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier merged commit d7af518 into main Mar 7, 2024
17 checks passed
@ArthurSens ArthurSens deleted the bump-common branch March 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants