Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote): add support prometheus remote write/read ProxyConfig #6512

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dongjiang1989
Copy link
Contributor

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

add support prometheus remote write/read ProxyConfig

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

add support prometheus remote write/read ProxyConfig 

Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 requested a review from a team as a code owner April 15, 2024 09:46
@simonpasquier
Copy link
Contributor

Thanks for looking into it! It'd be better to fix #6523 first. It would be super dope if you tackle first :)

@dongjiang1989
Copy link
Contributor Author

Thanks for looking into it! It'd be better to fix #6523 first. It would be super dope if you tackle first :)

Got it. I'll add a PR to fix it.

@slashpai
Copy link
Contributor

Thanks for looking into it! It'd be better to fix #6523 first. It would be super dope if you tackle first :)

Got it. I'll add a PR to fix it.

Thank you. Could you please create the PR to release-0.73 branch so we can include the fix in patch release?
#6527

@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented Apr 19, 2024

Thanks for looking into it! It'd be better to fix #6523 first. It would be super dope if you tackle first :)

Got it. I'll add a PR to fix it.

Thank you. Could you please create the PR to release-0.73 branch so we can include the fix in patch release? #6527

Got it. ref #6541

@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented May 15, 2024

@simonpasquier @slashpai #6541 have been merged.
PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants