fix: alertmanager: Add TLS-assets for email and webhook receivers to assets secret when using alertmanagerConfiguration

[name212]

Description

When we are using alertmanagerConfiguration email and webhook receivers from this config which contain TLS setting (TLS-assets), they do not add in internal store and therese assets do not save to TLS-assets secret which will mounted to alert manager pod.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Add TLS-assets for email and webhook receivers to assets secret when using alertmanagerConfiguration

[simonpasquier]

Are you using it for the global AlertmanagerConfig? Otherwise the operator should already load the TLS assets into the store.

[name212]

Are you using it for the global AlertmanagerConfig

Yes.

[simonpasquier]

My recommendation would be to call checkAlertmanagerConfigResource() on the global AlertmanagerConfig object which we don't IIUC. E.g. before calling initializeFromAlertmanagerConfig()

prometheus-operator/pkg/alertmanager/operator.go

Lines 861 to 871 in 48e9858

	// Load the base configuration from the referenced AlertmanagerConfig.
	globalAmConfig, err := c.mclient.MonitoringV1alpha1().AlertmanagerConfigs(am.Namespace).
	Get(ctx, am.Spec.AlertmanagerConfiguration.Name, metav1.GetOptions{})
	if err != nil {
	return fmt.Errorf("failed to get global AlertmanagerConfig: %w", err)
	}
	err = cfgBuilder.initializeFromAlertmanagerConfig(ctx, am.Spec.AlertmanagerConfiguration.Global, globalAmConfig)
	if err != nil {
	return fmt.Errorf("failed to initialize from global AlertmangerConfig: %w", err)
	}