Extend Counters, Summaries and Histograms with creation timestamp #1313

ArthurSens · 2023-07-19T00:10:29Z

Following our design doc, this PR aims to add created timestamp to counters, summaries, and histograms when using Prometheus protobuf.

TheSpiritXIII

Good start! I'm going to have to research MetricVec myself...

examples/exemplars/main.go

prometheus/counter.go

bwplotka

Thanks! So far so good, @TheSpiritXIII comments are solid 👍🏽

Let's make sure that when OpenMetrics text format is used we DON'T create separate series unless instrumentation explicitly enable that in the promhttp config.

examples/exemplars/main.go

prometheus/value.go

bwplotka

Looks good so far, some comments to make it even more correct and readable. Let me know if those make sense!

Thanks!

prometheus/promhttp/http_test.go

prometheus/summary.go

prometheus/counter.go

prometheus/counter_test.go

prometheus/histogram.go

prometheus/counter_test.go

prometheus/promhttp/http.go

bwplotka

Looks good so far, module some comments.

ArthurSens · 2023-08-04T18:37:26Z

Thanks for all the reviews so far!

@bwplotka, @TheSpiritXIII, @macxamin, it should be ready for another round of reviews :)

prometheus/counter.go

ArthurSens · 2023-08-15T18:45:37Z

@kakkoyun, the PR should be basically ready! There is only one test that I can't figure out what it does and how to fix though 😢

When you have the time, could you take a look at TestHandler and provide any suggestions on how to fix it?

bwplotka

Nice! Almost there. Is test handler still a problem? I can see tests passed?

prometheus/counter_test.go

prometheus/examples_test.go

prometheus/metric.go

prometheus/summary.go

prometheus/value.go

ArthurSens · 2023-08-24T20:11:28Z

Nice! Almost there. Is test handler still a problem? I can see tests passed?

I've shared it with Kemal on slack and forgot to post it here... I made changes to make the test pass, but I honestly don't understand what is being tested there. It would be nice if someone could double check if what I added makes sense or if I'm just hacking some way to make the test pass 😬

ArthurSens · 2023-08-24T20:15:52Z

Thanks for all the suggestions again bartek! I agree it looks ugly to have duplicated now functions between Counter/CounterOpts and similars, but so far I couldn't find a way to remove it from one of them since it is used by both in different situations. .*Opts use it for CreatedTimestamp initiation while counter|histograms use them for exemplars

I've also realized that I'm still not updating CreatedTimestamps when Histograms are reset. I'm hoping this could be done in a separate PR though 😅

bwplotka

It needs rebase, otherwise LGTM! 💪🏽

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>

Changes: * Comments for "now" are more explicit and not inlined. * populateMetrics is simpler and bit more efficient without timestamp to time to timestamp conversionts for more common code. * Test consistency and simplicity - the fewer variables the better. * Fixed inconsistency for v2 and MetricVec - let's pass opt.now consistently. * We don't need TestCounterXXXTimestamp - we test CT in many other places already. * Added more involved test for counter vectors with created timestamp. * Refactored normalization for simplicity. * Make histogram, summaries now consistent. * Simplified histograms CT flow and implemented proper CT on reset. TODO for next PRs: * NewConstSummary and NewConstHistogram - ability to specify CTs there. Signed-off-by: bwplotka <bwplotka@gmail.com>

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

ArthurSens · 2023-09-20T20:59:13Z

The failing test seems to be unrelated, but I'm not sure 🤨

bwplotka · 2023-09-21T09:46:44Z

It's fixed here #1348, so your PR should be good to go!

….0 (#939) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1293 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1297 - ci: define minimal permissions to GitHub workflows by [@diogoteles08](https://togithub.com/diogoteles08) in [prometheus/client_golang#1295 - Do not allocate memory when there's no constraints by [@Okhoshi](https://togithub.com/Okhoshi) in [prometheus/client_golang#1296 - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1306 - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1307 - histogram: Enable detection of a native histogram without observations by [@beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1314 - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1305 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1302 - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@tigrato](https://togithub.com/tigrato) in [prometheus/client_golang#1318 - Add missing tick "\`" in README by [@ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [prometheus/client_golang#1321 - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1320 - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1319 - docs: trivial grammar fixes to improve readability in promauto Godoc by [@sengi](https://togithub.com/sengi) in [prometheus/client_golang#1322 - Add Go 1.21 support by [@kakkoyun](https://togithub.com/kakkoyun) in [prometheus/client_golang#1325 - Bump client_model by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1323 - histogram docs: Fixed minor nit. by [@bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1324 - Update building by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1326 - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1331 - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1329 - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1328 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1284 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1330 - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1304 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1332 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1338 - Cleanup golangci-lint errcheck by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1339 - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1348 - Extend Counters, Summaries and Histograms with creation timestamp by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1313 - Fix typos in comments, tests, and errors by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1346 - Deprecated comment should begin with "Deprecated:" by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1347 - Add changelog entry for 1.17 by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1352 </details> #### New Contributors * @diogoteles08 made their first contributi[prometheus/client_golang#1295 * @tigrato made their first contributi[prometheus/client_golang#1318 * @ZiViZiViZ made their first contributi[prometheus/client_golang#1321 * @sengi made their first contributi[prometheus/client_golang#1322 * @ArthurSens made their first contributi[prometheus/client_golang#1323 * @alexandear made their first contributi[prometheus/client_golang#1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1293 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1297 - ci: define minimal permissions to GitHub workflows by [@diogoteles08](https://togithub.com/diogoteles08) in [prometheus/client_golang#1295 - Do not allocate memory when there's no constraints by [@Okhoshi](https://togithub.com/Okhoshi) in [prometheus/client_golang#1296 - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1306 - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1307 - histogram: Enable detection of a native histogram without observations by [@beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1314 - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1305 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1302 - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@tigrato](https://togithub.com/tigrato) in [prometheus/client_golang#1318 - Add missing tick "\`" in README by [@ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [prometheus/client_golang#1321 - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1320 - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1319 - docs: trivial grammar fixes to improve readability in promauto Godoc by [@sengi](https://togithub.com/sengi) in [prometheus/client_golang#1322 - Add Go 1.21 support by [@kakkoyun](https://togithub.com/kakkoyun) in [prometheus/client_golang#1325 - Bump client_model by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1323 - histogram docs: Fixed minor nit. by [@bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1324 - Update building by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1326 - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1331 - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1329 - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1328 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1284 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1330 - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1304 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1332 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1338 - Cleanup golangci-lint errcheck by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1339 - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1348 - Extend Counters, Summaries and Histograms with creation timestamp by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1313 - Fix typos in comments, tests, and errors by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1346 - Deprecated comment should begin with "Deprecated:" by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1347 - Add changelog entry for 1.17 by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1352 </details> #### New Contributors * @diogoteles08 made their first contributi[prometheus/client_golang#1295 * @tigrato made their first contributi[prometheus/client_golang#1318 * @ZiViZiViZ made their first contributi[prometheus/client_golang#1321 * @sengi made their first contributi[prometheus/client_golang#1322 * @ArthurSens made their first contributi[prometheus/client_golang#1323 * @alexandear made their first contributi[prometheus/client_golang#1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/hcloud-cloud-controller-manager).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

….0 (#4144) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1293 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1297 - ci: define minimal permissions to GitHub workflows by [@diogoteles08](https://togithub.com/diogoteles08) in [prometheus/client_golang#1295 - Do not allocate memory when there's no constraints by [@Okhoshi](https://togithub.com/Okhoshi) in [prometheus/client_golang#1296 - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1306 - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1307 - histogram: Enable detection of a native histogram without observations by [@beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1314 - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1305 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1302 - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@tigrato](https://togithub.com/tigrato) in [prometheus/client_golang#1318 - Add missing tick "\`" in README by [@ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [prometheus/client_golang#1321 - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1320 - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1319 - docs: trivial grammar fixes to improve readability in promauto Godoc by [@sengi](https://togithub.com/sengi) in [prometheus/client_golang#1322 - Add Go 1.21 support by [@kakkoyun](https://togithub.com/kakkoyun) in [prometheus/client_golang#1325 - Bump client_model by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1323 - histogram docs: Fixed minor nit. by [@bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1324 - Update building by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1326 - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1331 - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1329 - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1328 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1284 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1330 - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1304 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1332 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/client_golang#1338 - Cleanup golangci-lint errcheck by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1339 - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1348 - Extend Counters, Summaries and Histograms with creation timestamp by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1313 - Fix typos in comments, tests, and errors by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1346 - Deprecated comment should begin with "Deprecated:" by [@alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1347 - Add changelog entry for 1.17 by [@ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1352 </details> #### New Contributors * @diogoteles08 made their first contributi[prometheus/client_golang#1295 * @tigrato made their first contributi[prometheus/client_golang#1318 * @ZiViZiViZ made their first contributi[prometheus/client_golang#1321 * @sengi made their first contributi[prometheus/client_golang#1322 * @ArthurSens made their first contributi[prometheus/client_golang#1323 * @alexandear made their first contributi[prometheus/client_golang#1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack).

Particularly to bring in a performance fix prometheus/client_golang#1296. Most changes are fixing spelling or punctuation in spelling, but there is also the addition of creation timestamps from prometheus/client_golang#1313.

TheSpiritXIII suggested changes Jul 24, 2023

View reviewed changes

examples/exemplars/main.go Outdated Show resolved Hide resolved

prometheus/counter.go Outdated Show resolved Hide resolved

bwplotka reviewed Jul 26, 2023

View reviewed changes

examples/exemplars/main.go Outdated Show resolved Hide resolved

ArthurSens force-pushed the created-timestamps branch 3 times, most recently from 02ae425 to 7462b99 Compare July 27, 2023 21:45

ArthurSens commented Jul 27, 2023

View reviewed changes

prometheus/value.go Outdated Show resolved Hide resolved

ArthurSens force-pushed the created-timestamps branch 3 times, most recently from fd84017 to 81903d4 Compare July 28, 2023 20:56

bwplotka reviewed Jul 31, 2023

View reviewed changes

bwplotka mentioned this pull request Aug 1, 2023

Add prometheus bridge open-telemetry/opentelemetry-go#4351

Closed

ArthurSens force-pushed the created-timestamps branch 3 times, most recently from 7453af0 to 8e4f899 Compare August 1, 2023 20:57

bwplotka reviewed Aug 2, 2023

View reviewed changes

prometheus/counter_test.go Outdated Show resolved Hide resolved

dashpole reviewed Aug 2, 2023

View reviewed changes

prometheus/histogram.go Outdated Show resolved Hide resolved

bwplotka reviewed Aug 4, 2023

View reviewed changes

prometheus/counter_test.go Outdated Show resolved Hide resolved

bwplotka reviewed Aug 4, 2023

View reviewed changes

prometheus/promhttp/http.go Outdated Show resolved Hide resolved

bwplotka reviewed Aug 4, 2023

View reviewed changes

ArthurSens force-pushed the created-timestamps branch 3 times, most recently from 778ecfe to 6790767 Compare August 4, 2023 18:30

ArthurSens changed the title ~~Populate OM's created timestamps~~ Extend Counters, Summaries and Histograms with creation timestamp Aug 4, 2023

ArthurSens marked this pull request as ready for review August 4, 2023 18:33

ArthurSens force-pushed the created-timestamps branch from 6790767 to 7ba2507 Compare August 4, 2023 18:35

bwplotka reviewed Aug 4, 2023

View reviewed changes

prometheus/counter.go Outdated Show resolved Hide resolved

prometheus/counter.go Show resolved Hide resolved

ArthurSens mentioned this pull request Aug 7, 2023

Bump client_model #1323

Merged

ArthurSens force-pushed the created-timestamps branch 2 times, most recently from 59086cc to 3f535a6 Compare August 11, 2023 21:43

ArthurSens force-pushed the created-timestamps branch 2 times, most recently from 64bd568 to 4573ab3 Compare August 15, 2023 18:39

ArthurSens force-pushed the created-timestamps branch from 4573ab3 to c7051e4 Compare August 15, 2023 19:47

bwplotka reviewed Aug 22, 2023

View reviewed changes

ArthurSens force-pushed the created-timestamps branch from c7051e4 to 226eb8d Compare August 24, 2023 20:05

GolanLevy mentioned this pull request Sep 6, 2023

[Question] Handling vast amount of time series as a result of model_name label kserve/modelmesh-serving#426

Open

bwplotka approved these changes Sep 20, 2023

View reviewed changes

ArthurSens and others added 4 commits September 20, 2023 17:48

Extend Counters, Summaries and Histograms with creation timestamp

c0994f7

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>

Backport created timestamp to existing tests

0427023

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>

Update prometheus/counter_test.go

e5639d1

Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>

ArthurSens force-pushed the created-timestamps branch from 5151a52 to e5639d1 Compare September 20, 2023 20:48

ArthurSens mentioned this pull request Sep 20, 2023

Generate expected metrics from go1.21 #1349

Closed

bwplotka merged commit df7fa49 into prometheus:main Sep 21, 2023
6 of 7 checks passed

dashpole mentioned this pull request Sep 29, 2023

Prometheus bridge: Verify that prometheus start timestamps are working correctly open-telemetry/opentelemetry-go-contrib#4354

Closed

bboreham mentioned this pull request Oct 2, 2023

Update prometheus/client_golang to 1.17.0 grafana/mimir#6192

Merged

ArthurSens mentioned this pull request Oct 10, 2023

add _created support: add createdTime() method to counter #1044

Closed

ty-dc mentioned this pull request Jan 2, 2024

[dependencies] update prometheus/client_golang v1.16.0 to v1.18.0 kubernetes/kubernetes#122551

Closed

jwcesign mentioned this pull request Apr 19, 2024

upgrade: upgrade dependencies github.com/prometheus/common to the newest version kubernetes/kubernetes#124346

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend Counters, Summaries and Histograms with creation timestamp #1313

Extend Counters, Summaries and Histograms with creation timestamp #1313

ArthurSens commented Jul 19, 2023 •

edited

TheSpiritXIII left a comment

bwplotka left a comment

bwplotka left a comment

bwplotka left a comment

ArthurSens commented Aug 4, 2023

ArthurSens commented Aug 15, 2023

bwplotka left a comment

ArthurSens commented Aug 24, 2023

ArthurSens commented Aug 24, 2023

bwplotka left a comment

ArthurSens commented Sep 20, 2023

bwplotka commented Sep 21, 2023

Extend Counters, Summaries and Histograms with creation timestamp #1313

Extend Counters, Summaries and Histograms with creation timestamp #1313

Conversation

ArthurSens commented Jul 19, 2023 • edited

TheSpiritXIII left a comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka left a comment

Choose a reason for hiding this comment

ArthurSens commented Aug 4, 2023

ArthurSens commented Aug 15, 2023

bwplotka left a comment

Choose a reason for hiding this comment

ArthurSens commented Aug 24, 2023

ArthurSens commented Aug 24, 2023

bwplotka left a comment

Choose a reason for hiding this comment

ArthurSens commented Sep 20, 2023

bwplotka commented Sep 21, 2023

ArthurSens commented Jul 19, 2023 •

edited