Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement changes needed to support UTF8 metric and label names in Prometheus #1369

Closed
1 task
ywwg opened this issue Oct 25, 2023 · 5 comments
Closed
1 task
Assignees

Comments

@ywwg
Copy link
Contributor

ywwg commented Oct 25, 2023

ref: https://github.com/prometheus/proposals/blob/main/proposals/2023-08-21-utf8.md

Some changes are needed in this library to support the utf8 proposal:

  • optionally skip name validation depending on negotiated version.

More tasks may be added as needed.

@ywwg
Copy link
Contributor Author

ywwg commented Dec 8, 2023

This is a noop for handling validation itself, but work will be needed here to handle the content negotiation and what format to serve depending on that

@ywwg
Copy link
Contributor Author

ywwg commented Jan 11, 2024

It looks like almost nothing needs to be done to the agent other than setting the appropriate library values.
Draft: #1431

@ywwg ywwg mentioned this issue Jan 11, 2024
@ywwg
Copy link
Contributor Author

ywwg commented Feb 6, 2024

all diffs have vanished, no changes needed

@ywwg ywwg closed this as completed Feb 6, 2024
@ywwg
Copy link
Contributor Author

ywwg commented Feb 14, 2024

reopening -- the content negotiation changes break some tests and will need fixing

@ywwg ywwg reopened this Feb 14, 2024
@ywwg
Copy link
Contributor Author

ywwg commented Feb 23, 2024

fixed now #1448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants