Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.circleci: Add config to test against go1.18 #1006

Merged
merged 2 commits into from Mar 17, 2022
Merged

.circleci: Add config to test against go1.18 #1006

merged 2 commits into from Mar 17, 2022

Conversation

kakkoyun
Copy link
Member

Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com

@kakkoyun
Copy link
Member Author

kakkoyun commented Mar 17, 2022 •
edited

Too soon :/
It was a circleci issue. We needed to upgrade orb config for new convinient images https://circleci.com/developer/images/image/cimg/go

@kakkoyun kakkoyun force-pushed the test_go118 branch 3 times, most recently from b61a46d to 08360ca Compare March 17, 2022 13:24
@kakkoyun
Add config to test against go1.18
443e5b4 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun
Try to fix circleci
4f78fe2 
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
@kakkoyun kakkoyun requested a review from bwplotka March 17, 2022 13:40
bwplotka
bwplotka approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@bwplotka bwplotka merged commit 5d78aaa into main Mar 17, 2022
@bwplotka bwplotka deleted the test_go118 branch March 17, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kakkoyun @bwplotka